Commit 9b1ebce6 authored by Su Hui's avatar Su Hui Committed by Jens Axboe
Browse files

block: sed-opal: avoid possible wrong address reference in read_sed_opal_key() 



Clang static checker (scan-build) warning:
block/sed-opal.c:line 317, column 3
Value stored to 'ret' is never read.

Fix this problem by returning the error code when keyring_search() failed.
Otherwise, 'key' will have a wrong value when 'kerf' stores the error code.

Fixes: 3bfeb612 ("block: sed-opal: keyring support for SED keys")
Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20240611073659.429582-1-suhui@nfschina.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 27d02423

block/sed-opal.c

+1 −1
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ static int read_sed_opal_key(const char *key_name, u_char *buffer, int buflen) 
			      &key_type_user, key_name, true);



	if (IS_ERR(kref))

		ret = PTR_ERR(kref);

		return PTR_ERR(kref);



	key = key_ref_to_ptr(kref);

	down_read(&key->sem);