Commit 9b2348e2 authored by Jiri Pirko's avatar Jiri Pirko Committed by Paolo Abeni
Browse files

devlink: warn about existing entities during reload-reinit 



During reload-reinit, all entities except for params, resources, regions
and health reporter should be removed and re-added. Add a warning to
be triggered in case the driver behaves differently.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 15d74e65

net/devlink/dev.c

+15 −1
Original line number Diff line number Diff line
@@ -425,6 +425,18 @@ static void devlink_reload_netns_change(struct devlink *devlink, 
	devlink_rel_nested_in_notify(devlink);

}



static void devlink_reload_reinit_sanity_check(struct devlink *devlink)

{

	WARN_ON(!list_empty(&devlink->trap_policer_list));

	WARN_ON(!list_empty(&devlink->trap_group_list));

	WARN_ON(!list_empty(&devlink->trap_list));

	WARN_ON(!list_empty(&devlink->dpipe_table_list));

	WARN_ON(!list_empty(&devlink->sb_list));

	WARN_ON(!list_empty(&devlink->rate_list));

	WARN_ON(!list_empty(&devlink->linecard_list));

	WARN_ON(!xa_empty(&devlink->ports));

}



int devlink_reload(struct devlink *devlink, struct net *dest_net,

		   enum devlink_reload_action action,

		   enum devlink_reload_limit limit,
@@ -452,8 +464,10 @@ int devlink_reload(struct devlink *devlink, struct net *dest_net, 
	if (dest_net && !net_eq(dest_net, curr_net))

		devlink_reload_netns_change(devlink, curr_net, dest_net);



	if (action == DEVLINK_RELOAD_ACTION_DRIVER_REINIT)

	if (action == DEVLINK_RELOAD_ACTION_DRIVER_REINIT) {

		devlink_params_driverinit_load_new(devlink);

		devlink_reload_reinit_sanity_check(devlink);

	}



	err = devlink->ops->reload_up(devlink, action, limit, actions_performed, extack);

	devlink_reload_failed_set(devlink, !!err);