Commit 9b5f8ee4 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: sh: Use standard helper for buffer accesses 



The SH DAC audio driver uses the kmalloc'ed buffer as the main PCM
buffer, and the data is transferred via hrtimer callbacks manually
from there to the hardware.  Meanwhile, some of its code are written
as if the buffer is on iomem and use the special helpers for the iomem
(e.g. copy_from_iter_toio() or memset_io()).  Those are rather useless
and the standard helpers should be used.

Similarly, the PCM mmap callback is set to a special one with
snd_pcm_lib_mmap_iomem, but this is also nonsense, because SH
architecture doesn't support this function, hence it leads just to
NULL -- the fallback to the standard helper.

This patch replaces those special setups with the standard ones.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411281337.I4M07b7i-lkp@intel.com/
Link: https://patch.msgid.link/20241128104939.13755-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 4f9d6743

sound/sh/sh_dac_audio.c

+2 −3
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ static int snd_sh_dac_pcm_copy(struct snd_pcm_substream *substream, 
	/* channel is not used (interleaved data) */

	struct snd_sh_dac *chip = snd_pcm_substream_chip(substream);



	if (copy_from_iter_toio(chip->data_buffer + pos, src, count))

	if (copy_from_iter(chip->data_buffer + pos, src, count) != count)

		return -EFAULT;

	chip->buffer_end = chip->data_buffer + pos + count;
@@ -182,7 +182,7 @@ static int snd_sh_dac_pcm_silence(struct snd_pcm_substream *substream, 
	/* channel is not used (interleaved data) */

	struct snd_sh_dac *chip = snd_pcm_substream_chip(substream);



	memset_io(chip->data_buffer + pos, 0, count);

	memset(chip->data_buffer + pos, 0, count);

	chip->buffer_end = chip->data_buffer + pos + count;



	if (chip->empty) {
@@ -211,7 +211,6 @@ static const struct snd_pcm_ops snd_sh_dac_pcm_ops = { 
	.pointer	= snd_sh_dac_pcm_pointer,

	.copy		= snd_sh_dac_pcm_copy,

	.fill_silence	= snd_sh_dac_pcm_silence,

	.mmap		= snd_pcm_lib_mmap_iomem,

};



static int snd_sh_dac_pcm(struct snd_sh_dac *chip, int device)