Commit 9b8a79f4 authored by Sebastian Muxel's avatar Sebastian Muxel Committed by Jonathan Corbet
Browse files

scripts: sphinx-pre-install: remove unnecessary double check for $cur_version 



$cur_version is currently being tested twice with the first test
resulting in an unhelpful "$sphinx returned an error", not continuing to
the more helpful "$sphinx didn't return its version".

This patch removes the first test to return the more useful message.

Fixes: a8b380c3 ("scripts: sphinx-pre-install: only ask to activate valid venvs")
Signed-off-by: default avatarSebastian Muxel <sebastian@muxel.dev>
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20240827133224.160776-1-sebastian@muxel.dev
parent bc6cb620

scripts/sphinx-pre-install

+0 −2
Original line number Diff line number Diff line
@@ -300,8 +300,6 @@ sub check_sphinx() 
	}



	$cur_version = get_sphinx_version($sphinx);

	die ("$sphinx returned an error") if (!$cur_version);



	die "$sphinx didn't return its version" if (!$cur_version);



	if ($cur_version lt $min_version) {