Unverified Commit 9b9c0adb authored by Dan Carpenter's avatar Dan Carpenter Committed by Ilpo Järvinen
Browse files

platform/x86: intel: punit_ipc: fix memory corruption 



This passes the address of the pointer "&punit_ipcdev" when the intent
was to pass the pointer itself "punit_ipcdev" (without the ampersand).
This means that the:

	complete(&ipcdev->cmd_complete);

in intel_punit_ioc() will write to a wrong memory address corrupting it.

Fixes: fdca4f16 ("platform:x86: add Intel P-Unit mailbox IPC driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSCmoBipSQ_tlD-D@stanley.mountain


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 752630cb

drivers/platform/x86/intel/punit_ipc.c

+1 −1
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ static int intel_punit_ipc_probe(struct platform_device *pdev) 
	} else {

		ret = devm_request_irq(&pdev->dev, irq, intel_punit_ioc,

				       IRQF_NO_SUSPEND, "intel_punit_ipc",

				       &punit_ipcdev);

				       punit_ipcdev);

		if (ret) {

			dev_err(&pdev->dev, "Failed to request irq: %d\n", irq);

			return ret;