Commit 9bd24927 authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Marc Kleine-Budde
Browse files

can: ctucanfd: handle skb allocation failure 



If skb allocation fails, the pointer to struct can_frame is NULL. This
is actually handled everywhere inside ctucan_err_interrupt() except for
the only place.

Add the missed NULL check.

Found by Linux Verification Center (linuxtesting.org) with SVACE static
analysis tool.

Fixes: 2dcb8e87 ("can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Acked-by: default avatarPavel Pisa <pisa@cmp.felk.cvut.cz>
Reviewed-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://patch.msgid.link/20250114152138.139580-1-pchelkin@ispras.ru


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 44de577e

drivers/net/can/ctucanfd/ctucanfd_base.c

+6 −4
Original line number Diff line number Diff line
@@ -867,10 +867,12 @@ static void ctucan_err_interrupt(struct net_device *ndev, u32 isr) 
			}

			break;

		case CAN_STATE_ERROR_ACTIVE:

			if (skb) {

				cf->can_id |= CAN_ERR_CNT;

				cf->data[1] = CAN_ERR_CRTL_ACTIVE;

				cf->data[6] = bec.txerr;

				cf->data[7] = bec.rxerr;

			}

			break;

		default:

			netdev_warn(ndev, "unhandled error state (%d:%s)!\n",