Commit 9c0acc16 authored by Guangshuo Li's avatar Guangshuo Li Committed by Rafael J. Wysocki
Browse files

ACPI: scan: Use acpi_dev_put() in object add error paths 



After acpi_init_device_object(), the lifetime of struct acpi_device is
managed by the driver core through reference counting.

Both acpi_add_power_resource() and acpi_add_single_object() call
acpi_init_device_object() and then invoke acpi_device_add(). If that
fails, their error paths call the release callback directly instead of
dropping the device reference through acpi_dev_put().

This bypasses the normal device lifetime rules and frees the object
without releasing the reference acquired by device_initialize(), which
may lead to a refcount leak.

The issue was identified by a static analysis tool I developed and
confirmed by manual review.

Fix both error paths by using acpi_dev_put() and let the release
callback handle the final cleanup.

Fixes: 781d737c ("ACPI: Drop power resources driver")
Fixes: 718fb0de ("ACPI: fix NULL bug for HID/UID string")
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: default avatarGuangshuo Li <lgs201920130244@gmail.com>
Link: https://patch.msgid.link/20260413135343.2884481-1-lgs201920130244@gmail.com


Signed-off-by: default avatarRafael J. Wysocki <rjw@rjwysocki.net>
parent 2e31b161

drivers/acpi/power.c

+1 −1
Original line number Diff line number Diff line
@@ -987,7 +987,7 @@ struct acpi_device *acpi_add_power_resource(acpi_handle handle) 
	return device;



 err:

	acpi_release_power_resource(&device->dev);

	acpi_dev_put(device);

	return NULL;

}

drivers/acpi/scan.c

+1 −1
Original line number Diff line number Diff line
@@ -1900,7 +1900,7 @@ static int acpi_add_single_object(struct acpi_device **child, 
		result = acpi_device_add(device);



	if (result) {

		acpi_device_release(&device->dev);

		acpi_dev_put(device);

		return result;

	}