Unverified Commit 9c0f5bbf authored by Simon Trimmer's avatar Simon Trimmer Committed by Mark Brown
Browse files

ASoC: cs35l56: Log SoundWire status updates only on changes 



The SoundWire slave update_status() callback can be invoked when the
status has not changed. To prevent large amounts of log noise with debug
enabled, log them only when the status changes. This also helps with
understanding them, because they now log an actual change in state.

Signed-off-by: default avatarSimon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260514151854.695145-1-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c996a441

sound/soc/codecs/cs35l56-sdw.c

+3 −2
Original line number Diff line number Diff line
@@ -385,17 +385,18 @@ static int cs35l56_sdw_update_status(struct sdw_slave *peripheral, 


	switch (status) {

	case SDW_SLAVE_ATTACHED:

		dev_dbg(cs35l56->base.dev, "%s: ATTACHED\n", __func__);

		cs35l56->sdw_in_clock_stop_1 = false;

		if (cs35l56->sdw_attached)

			break;



		dev_dbg(cs35l56->base.dev, "%s: ATTACHED\n", __func__);

		if (!cs35l56->base.init_done || cs35l56->soft_resetting)

			cs35l56_sdw_init(peripheral);



		cs35l56->sdw_attached = true;

		break;

	case SDW_SLAVE_UNATTACHED:

		if (cs35l56->sdw_attached)

			dev_dbg(cs35l56->base.dev, "%s: UNATTACHED\n", __func__);

		cs35l56->sdw_attached = false;

		break;