Commit 9c20cb8b authored by Giovanni Cabiddu's avatar Giovanni Cabiddu Committed by Herbert Xu
Browse files

crypto: qat - ignore subsequent state up commands 



If the device is already in the up state, a subsequent write of `up` to
the sysfs attribute /sys/bus/pci/devices/<BDF>/qat/state brings the
device down.
Fix this behaviour by ignoring subsequent `up` commands if the device is
already in the up state.

Fixes: 1bdc8555 ("crypto: qat - fix concurrency issue when device state changes")
Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: default avatarAdam Guerin <adam.guerin@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent c362a58e

drivers/crypto/intel/qat/qat_common/adf_sysfs.c

+3 −1
Original line number Diff line number Diff line
@@ -68,7 +68,9 @@ static ssize_t state_store(struct device *dev, struct device_attribute *attr, 
		dev_info(dev, "Starting device qat_dev%d\n", accel_id);



		ret = adf_dev_up(accel_dev, true);

		if (ret < 0) {

		if (ret == -EALREADY) {

			break;

		} else if (ret) {

			dev_err(dev, "Failed to start device qat_dev%d\n",

				accel_id);

			adf_dev_down(accel_dev, true);