Commit 9c505308 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt (Google)
Browse files

tracing: Exit out immediately after update_marker_trace() 

The call to update_marker_trace() in set_tracer_flag() performs the update
to the tr->trace_flags. There's no reason to perform it again after it is
called. Return immediately instead.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: https://patch.msgid.link/20251106003501.726406870@kernel.org


Reviewed-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 5aa0d18d

kernel/trace/trace.c

+4 −1
Original line number Diff line number Diff line
@@ -5254,8 +5254,11 @@ int set_tracer_flag(struct trace_array *tr, u64 mask, int enabled) 
		}

	}



	if (mask == TRACE_ITER(COPY_MARKER))

	if (mask == TRACE_ITER(COPY_MARKER)) {

		update_marker_trace(tr, enabled);

		/* update_marker_trace updates the tr->trace_flags */

		return 0;

	}



	if (enabled)

		tr->trace_flags |= mask;