Commit 9c573074 authored by Zhu Wang's avatar Zhu Wang Committed by Bartosz Golaszewski
Browse files

gpio: max732x: remove redundant CONFIG_OF and of_match_ptr() 



The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here. We remove both CONFIG_OF and of_match_ptr() here.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it.

Signed-off-by: default avatarZhu Wang <wangzhu9@huawei.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent c4dc167c

drivers/gpio/gpio-max732x.c

+1 −5
Original line number Diff line number Diff line
@@ -18,8 +18,6 @@ 
#include <linux/interrupt.h>

#include <linux/i2c.h>

#include <linux/platform_data/max732x.h>

#include <linux/of.h>





/*

 * Each port of MAX732x (including MAX7319) falls into one of the
@@ -114,7 +112,6 @@ static const struct i2c_device_id max732x_id[] = { 
};

MODULE_DEVICE_TABLE(i2c, max732x_id);



#ifdef CONFIG_OF

static const struct of_device_id max732x_of_table[] = {

	{ .compatible = "maxim,max7319" },

	{ .compatible = "maxim,max7320" },
@@ -128,7 +125,6 @@ static const struct of_device_id max732x_of_table[] = { 
	{ }

};

MODULE_DEVICE_TABLE(of, max732x_of_table);

#endif



struct max732x_chip {

	struct gpio_chip gpio_chip;
@@ -709,7 +705,7 @@ static int max732x_probe(struct i2c_client *client) 
static struct i2c_driver max732x_driver = {

	.driver = {

		.name		= "max732x",

		.of_match_table	= of_match_ptr(max732x_of_table),

		.of_match_table	= max732x_of_table,

	},

	.probe		= max732x_probe,

	.id_table	= max732x_id,