Unverified Commit 9c75986a authored by Johan Hovold's avatar Johan Hovold Committed by Stephen Boyd
Browse files

clk: keystone: syscon-clk: fix regmap leak on probe failure 



The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: a250cd4c ("clk: keystone: syscon-clk: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org	# 6.15
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent cf33f0b7

drivers/clk/keystone/syscon-clk.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ static int ti_syscon_gate_clk_probe(struct platform_device *pdev) 
	if (IS_ERR(base))

		return PTR_ERR(base);



	regmap = regmap_init_mmio(dev, base, &ti_syscon_regmap_cfg);

	regmap = devm_regmap_init_mmio(dev, base, &ti_syscon_regmap_cfg);

	if (IS_ERR(regmap))

		return dev_err_probe(dev, PTR_ERR(regmap),

				     "failed to get regmap\n");