Commit 9c79b779 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Vinod Koul
Browse files

phy: rockchip: fix CONFIG_TYPEC dependency 



The newly added driver causes a warning about missing dependencies
by selecting CONFIG_TYPEC unconditionally:

WARNING: unmet direct dependencies detected for TYPEC
  Depends on [n]: USB_SUPPORT [=n]
  Selected by [y]:
  - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y]

WARNING: unmet direct dependencies detected for USB_COMMON
  Depends on [n]: USB_SUPPORT [=n]
  Selected by [y]:
  - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y]

Since that is a user-visible option, it should not really be selected
in the first place. Replace the 'select' with a 'depends on' as
we have for similar drivers.

Fixes: 2f70bbdd ("phy: rockchip: add usbdp combo phy driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240415174241.77982-1-arnd@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c9342d1a

drivers/phy/rockchip/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -119,8 +119,8 @@ config PHY_ROCKCHIP_USB 
config PHY_ROCKCHIP_USBDP

	tristate "Rockchip USBDP COMBO PHY Driver"

	depends on ARCH_ROCKCHIP && OF

	depends on TYPEC

	select GENERIC_PHY

	select TYPEC

	help

	  Enable this to support the Rockchip USB3.0/DP combo PHY with

	  Samsung IP block. This is required for USB3 support on RK3588.