Commit 9c96821b authored Jan 10, 2025 by Christoph Hellwig Committed by Jens Axboe Jan 10, 2025

block: fix docs for freezing of queue limits updates



queue_limits_commit_update is the function that needs to operate on a
frozen queue, not queue_limits_start_update.  Update the kerneldoc
comments to reflect that.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20250110054726.1499538-2-hch@lst.de


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 844b8cdc

block/blk-settings.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -413,7 +413,8 @@ int blk_set_default_limits(struct queue_limits *lim)
		* @lim: limits to apply
		*
		* Apply the limits in @lim that were obtained from queue_limits_start_update()
		* and updated by the caller to @q.
		* and updated by the caller to @q. The caller must have frozen the queue or
		* ensure that there are no outstanding I/Os by other means.
		*
		* Returns 0 if successful, else a negative error code.
		*/

include/linux/blkdev.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -944,8 +944,7 @@ static inline unsigned int blk_boundary_sectors_left(sector_t offset,
		* the caller can modify. The caller must call queue_limits_commit_update()
		* to finish the update.
		*
		* Context: process context. The caller must have frozen the queue or ensured
		* that there is outstanding I/O by other means.
		* Context: process context.
		*/
		static inline struct queue_limits
		queue_limits_start_update(struct request_queue *q)