Commit 9cdc6423 authored by Mike Rapoport (Microsoft)'s avatar Mike Rapoport (Microsoft)
Browse files

memblock: allow zero threshold in validate_numa_converage() 

Currently memblock validate_numa_converage() returns false negative when
threshold set to zero.

Make the check if the memory size with invalid node ID is greater than
the threshold exclusive to fix that.

Link: https://lore.kernel.org/all/Z0mIDBD4KLyxyOCm@kernel.org/


Signed-off-by: default avatarMike Rapoport (Microsoft) <rppt@kernel.org>
parent bcc8eda6

mm/memblock.c

+2 −2
Original line number Diff line number Diff line
@@ -735,7 +735,7 @@ int __init_memblock memblock_add(phys_addr_t base, phys_addr_t size) 
/**

 * memblock_validate_numa_coverage - check if amount of memory with

 * no node ID assigned is less than a threshold

 * @threshold_bytes: maximal number of pages that can have unassigned node

 * @threshold_bytes: maximal memory size that can have unassigned node

 * ID (in bytes).

 *

 * A buggy firmware may report memory that does not belong to any node.
@@ -755,7 +755,7 @@ bool __init_memblock memblock_validate_numa_coverage(unsigned long threshold_byt 
			nr_pages += end_pfn - start_pfn;

	}



	if ((nr_pages << PAGE_SHIFT) >= threshold_bytes) {

	if ((nr_pages << PAGE_SHIFT) > threshold_bytes) {

		mem_size_mb = memblock_phys_mem_size() >> 20;

		pr_err("NUMA: no nodes coverage for %luMB of %luMB RAM\n",

		       (nr_pages << PAGE_SHIFT) >> 20, mem_size_mb);