Commit 9ce4a8c0 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Danilo Krummrich
Browse files

sysfs: attribute_group: Respect is_visible_const() when changing owner 



The call to grp->is_visible in sysfs_group_attrs_change_owner() was
missed when support for is_visible_const() was added.

Check for both is_visible variants there too.

Fixes: 7dd9fdb4 ("sysfs: attribute_group: enable const variants of is_visible()")
Cc: stable@vger.kernel.org
Reported-by: default avatarMichael Kelley <mhklinux@outlook.com>
Closes: https://lore.kernel.org/lkml/SN6PR02MB4157D5F04608E4E3C21AB56ED45EA@SN6PR02MB4157.namprd02.prod.outlook.com/
Link: https://sashiko.dev/#/patchset/20260403-sysfs-const-hv-v2-0-8932ab8d41db%40weissschuh.net


Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarMichael Kelley <mhklinux@outlook.com>
Link: https://patch.msgid.link/20260403-sysfs-is_visible_const-fix-v1-1-f87f26071d2c@weissschuh.net


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 8f4c13c2

fs/sysfs/group.c

+5 −2
Original line number Diff line number Diff line
@@ -517,8 +517,11 @@ static int sysfs_group_attrs_change_owner(struct kobject *kobj, 
		struct attribute *const *attr;



		for (i = 0, attr = grp->attrs; *attr; i++, attr++) {

			if (grp->is_visible) {

			if (grp->is_visible || grp->is_visible_const) {

				if (grp->is_visible)

					mode = grp->is_visible(kobj, *attr, i);

				else

					mode = grp->is_visible_const(kobj, *attr, i);

				if (mode & SYSFS_GROUP_INVISIBLE)

					break;

				if (!mode)