Commit 9d16a859 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Michael Ellerman
Browse files

powerpc: sgy_cts1000: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/1e8396078942d9e46e56d70ed2f749a76391c381.1708529736.git.u.kleine-koenig@pengutronix.de
parent 914d081e

arch/powerpc/platforms/85xx/sgy_cts1000.c

+2 −4
Original line number Diff line number Diff line
@@ -114,7 +114,7 @@ static int gpio_halt_probe(struct platform_device *pdev) 
	return ret;

}



static int gpio_halt_remove(struct platform_device *pdev)

static void gpio_halt_remove(struct platform_device *pdev)

{

	free_irq(halt_irq, pdev);

	cancel_work_sync(&gpio_halt_wq);
@@ -124,8 +124,6 @@ static int gpio_halt_remove(struct platform_device *pdev) 


	gpiod_put(halt_gpio);

	halt_gpio = NULL;



	return 0;

}



static const struct of_device_id gpio_halt_match[] = {
@@ -145,7 +143,7 @@ static struct platform_driver gpio_halt_driver = { 
		.of_match_table = gpio_halt_match,

	},

	.probe		= gpio_halt_probe,

	.remove		= gpio_halt_remove,

	.remove_new	= gpio_halt_remove,

};



module_platform_driver(gpio_halt_driver);