Commit 9d4e6ab8 authored by Vlastimil Babka's avatar Vlastimil Babka
Browse files

slab: simplify init_kmem_cache_nodes() error handling 



We don't need to call free_kmem_cache_nodes() immediately when failing
to allocate a kmem_cache_node, because when we return 0,
do_kmem_cache_create() calls __kmem_cache_release() which also performs
free_kmem_cache_nodes().

Reviewed-by: default avatarHarry Yoo <harry.yoo@oracle.com>
Reviewed-by: default avatarSuren Baghdasaryan <surenb@google.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
parent 212b0f07

mm/slub.c

+1 −3
Original line number Diff line number Diff line
@@ -5669,10 +5669,8 @@ static int init_kmem_cache_nodes(struct kmem_cache *s) 
		n = kmem_cache_alloc_node(kmem_cache_node,

						GFP_KERNEL, node);



		if (!n) {

			free_kmem_cache_nodes(s);

		if (!n)

			return 0;

		}



		init_kmem_cache_node(n);

		s->node[node] = n;