Commit 9d6a5304 authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Stephen Boyd
Browse files

clk: at91: Use of_property_count_u32_elems() to get property length 



Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731201407.1838385-7-robh@kernel.org


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent f9848cfa

drivers/clk/at91/dt-compat.c

+3 −2
Original line number Diff line number Diff line
@@ -563,9 +563,10 @@ of_at91_clk_pll_get_characteristics(struct device_node *np) 
	if (num_cells < 2 || num_cells > 4)

		return NULL;



	if (!of_get_property(np, "atmel,pll-clk-output-ranges", &tmp))

	num_output = of_property_count_u32_elems(np, "atmel,pll-clk-output-ranges");

	if (num_output <= 0)

		return NULL;

	num_output = tmp / (sizeof(u32) * num_cells);

	num_output /= num_cells;



	characteristics = kzalloc(sizeof(*characteristics), GFP_KERNEL);

	if (!characteristics)