Commit 9d900d4e authored by Jens Axboe's avatar Jens Axboe
Browse files

exit: abstract out should_wake helper for child_wait_callback() 



Abstract out the helper that decides if we should wake up following
a wake_up() callback on our internal waitqueue.

No functional changes intended in this patch.

Acked-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fc68fcda

kernel/exit.c

+14 −6
Original line number Diff line number Diff line
@@ -1520,6 +1520,17 @@ static int ptrace_do_wait(struct wait_opts *wo, struct task_struct *tsk) 
	return 0;

}



static bool pid_child_should_wake(struct wait_opts *wo, struct task_struct *p)

{

	if (!eligible_pid(wo, p))

		return false;



	if ((wo->wo_flags & __WNOTHREAD) && wo->child_wait.private != p->parent)

		return false;



	return true;

}



static int child_wait_callback(wait_queue_entry_t *wait, unsigned mode,

				int sync, void *key)

{
@@ -1527,13 +1538,10 @@ static int child_wait_callback(wait_queue_entry_t *wait, unsigned mode, 
						child_wait);

	struct task_struct *p = key;



	if (!eligible_pid(wo, p))

		return 0;

	if (pid_child_should_wake(wo, p))

		return default_wake_function(wait, mode, sync, key);



	if ((wo->wo_flags & __WNOTHREAD) && wait->private != p->parent)

	return 0;



	return default_wake_function(wait, mode, sync, key);

}



void __wake_up_parent(struct task_struct *p, struct task_struct *parent)