Commit 9d9929e9 authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Andi Shyti
Browse files

i2c: piix4: Change the parameter list of piix4_transaction function 



Currently, `piix4_transaction()` accepts only one parameter, which is the
`i2c_adapter` information. This approach works well as long as SB800 SMBus
port accesses are confined to the piix4 driver. However, with the
implementation of a separate ASF driver and the varying address spaces
across drivers, it is necessary to change the function parameter list of
`piix4_transaction()` to include the port address. This modification
allows other drivers that use piix4 to pass the specific port details they
need to operate on.

Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Co-developed-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent bd492b58

drivers/i2c/busses/i2c-piix4.c

+2 −4
Original line number Diff line number Diff line
@@ -536,10 +536,8 @@ static int piix4_setup_aux(struct pci_dev *PIIX4_dev, 
	return piix4_smba;

}



static int piix4_transaction(struct i2c_adapter *piix4_adapter)

static int piix4_transaction(struct i2c_adapter *piix4_adapter, unsigned short piix4_smba)

{

	struct i2c_piix4_adapdata *adapdata = i2c_get_adapdata(piix4_adapter);

	unsigned short piix4_smba = adapdata->smba;

	int temp;

	int result = 0;

	int timeout = 0;
@@ -675,7 +673,7 @@ static s32 piix4_access(struct i2c_adapter * adap, u16 addr, 


	outb_p((size & 0x1C) + (ENABLE_INT9 & 1), SMBHSTCNT);



	status = piix4_transaction(adap);

	status = piix4_transaction(adap, piix4_smba);

	if (status)

		return status;