Commit 9db2426a authored by Philipp Stanner's avatar Philipp Stanner Committed by Jakub Kicinski
Browse files

stmmac: loongson: Remove surplus loop 



loongson_dwmac_probe() contains a loop which doesn't have an effect,
because it tries to call pcim_iomap_regions() with the same parameters
several times. The break statement at the loop's end furthermore ensures
that the loop only runs once anyways.

Remove the surplus loop.

Signed-off-by: default avatarPhilipp Stanner <phasta@kernel.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarYanteng Si <si.yanteng@linux.dev>
Reviewed-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
Tested-by: default avatarHenry Chen <chenx97@aosc.io>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250324092928.9482-4-phasta@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 071ccde6

drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c

+4 −9
Original line number Diff line number Diff line
@@ -536,7 +536,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id 
	struct stmmac_pci_info *info;

	struct stmmac_resources res;

	struct loongson_data *ld;

	int ret, i;

	int ret;



	plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);

	if (!plat)
@@ -566,14 +566,9 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id 
	pci_set_master(pdev);



	/* Get the base address of device */

	for (i = 0; i < PCI_STD_NUM_BARS; i++) {

		if (pci_resource_len(pdev, i) == 0)

			continue;

	ret = pcim_iomap_regions(pdev, BIT(0), DRIVER_NAME);

	if (ret)

		goto err_disable_device;

		break;

	}



	memset(&res, 0, sizeof(res));

	res.addr = pcim_iomap_table(pdev)[0];