Commit 9dd3f1ef authored by Markus Elfring's avatar Markus Elfring Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: Return directly after a failed apmf_if_call() in... 


platform/x86/amd/pmf: Return directly after a failed apmf_if_call() in apmf_sbios_heartbeat_notify()

The kfree() function was called in one case by
the apmf_sbios_heartbeat_notify() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software.

* Thus return directly after a call of the function “apmf_if_call” failed
  at the beginning.

* Delete the label “out” which became unnecessary with this refactoring.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/362ee824-fc53-4e19-9529-8b621657635b@web.de


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 87d8f1ee

drivers/platform/x86/amd/pmf/acpi.c

+1 −3
Original line number Diff line number Diff line
@@ -135,11 +135,9 @@ static void apmf_sbios_heartbeat_notify(struct work_struct *work) 
	dev_dbg(dev->dev, "Sending heartbeat to SBIOS\n");

	info = apmf_if_call(dev, APMF_FUNC_SBIOS_HEARTBEAT, NULL);

	if (!info)

		goto out;

		return;



	schedule_delayed_work(&dev->heart_beat, msecs_to_jiffies(dev->hb_interval * 1000));



out:

	kfree(info);

}