Commit 9de722c1 authored by Rosen Penev's avatar Rosen Penev Committed by Jakub Kicinski
Browse files

net: mvneta: use ethtool_puts 



Allows simplifying get_strings and avoids manual pointer manipulation.

Tested on Turris Omnia.

Signed-off-by: default avatarRosen Penev <rosenp@gmail.com>
Reviewed-by: default avatarGerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20241011195955.7065-1-rosenp@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5bedbfc1

drivers/net/ethernet/marvell/mvneta.c

+1 −3
Original line number Diff line number Diff line
@@ -4795,11 +4795,9 @@ static void mvneta_ethtool_get_strings(struct net_device *netdev, u32 sset, 
		int i;



		for (i = 0; i < ARRAY_SIZE(mvneta_statistics); i++)

			memcpy(data + i * ETH_GSTRING_LEN,

			       mvneta_statistics[i].name, ETH_GSTRING_LEN);

			ethtool_puts(&data, mvneta_statistics[i].name);



		if (!pp->bm_priv) {

			data += ETH_GSTRING_LEN * ARRAY_SIZE(mvneta_statistics);

			page_pool_ethtool_stats_get_strings(data);

		}

	}