Commit 9e3ca33b authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

xprtrdma: Improve locking around rpcrdma_rep creation 



Defensive clean up: Protect the rb_all_reps list during rep
creation.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 8b5292be

net/sunrpc/xprtrdma/verbs.c

+5 −4
Original line number Diff line number Diff line
@@ -963,13 +963,11 @@ static void rpcrdma_reqs_reset(struct rpcrdma_xprt *r_xprt) 
		rpcrdma_req_reset(req);

}



/* No locking needed here. This function is called only by the

 * Receive completion handler.

 */

static noinline

struct rpcrdma_rep *rpcrdma_rep_create(struct rpcrdma_xprt *r_xprt,

				       bool temp)

{

	struct rpcrdma_buffer *buf = &r_xprt->rx_buf;

	struct rpcrdma_rep *rep;



	rep = kzalloc(sizeof(*rep), GFP_KERNEL);
@@ -996,7 +994,10 @@ struct rpcrdma_rep *rpcrdma_rep_create(struct rpcrdma_xprt *r_xprt, 
	rep->rr_recv_wr.sg_list = &rep->rr_rdmabuf->rg_iov;

	rep->rr_recv_wr.num_sge = 1;

	rep->rr_temp = temp;

	list_add(&rep->rr_all, &r_xprt->rx_buf.rb_all_reps);



	spin_lock(&buf->rb_lock);

	list_add(&rep->rr_all, &buf->rb_all_reps);

	spin_unlock(&buf->rb_lock);

	return rep;



out_free_regbuf: