Commit 9e935c0f authored by Abdun Nihaal's avatar Abdun Nihaal Committed by Johannes Berg
Browse files

wifi: brcmfmac: fix memory leak in brcmf_get_module_param 



The memory allocated for settings is not freed when brcmf_of_probe
fails. Fix that by freeing settings before returning in error path.

Fixes: 0ff08433 ("wifi: brcmfmac: Add optional lpo clock enable support")
Signed-off-by: default avatarAbdun Nihaal <abdun.nihaal@gmail.com>
Acked-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Link: https://patch.msgid.link/20250330103425.44197-1-abdun.nihaal@gmail.com


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent ff4ec537

drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c

+3 −1
Original line number Diff line number Diff line
@@ -561,8 +561,10 @@ struct brcmf_mp_device *brcmf_get_module_param(struct device *dev, 
	if (!found) {

		/* No platform data for this device, try OF and DMI data */

		brcmf_dmi_probe(settings, chip, chiprev);

		if (brcmf_of_probe(dev, bus_type, settings) == -EPROBE_DEFER)

		if (brcmf_of_probe(dev, bus_type, settings) == -EPROBE_DEFER) {

			kfree(settings);

			return ERR_PTR(-EPROBE_DEFER);

		}

		brcmf_acpi_probe(dev, bus_type, settings);

	}

	return settings;