Commit 9eddc819 authored by Ratheesh Kannoth's avatar Ratheesh Kannoth Committed by Jakub Kicinski
Browse files

octeontx2-af: npc: Fix allmulticast skip logic for LBK and SDP VFs 



When installing the allmulticast NPC rule, rvu_npc_install_allmulti_entry()
should skip LBK and SDP VFs (only CGX PF/VF may add the entry).  The
code combined is_lbk_vf() and is_sdp_vf() with logical AND, which is
never true for a single pcifunc, so the intended early return never ran.

Use logical OR instead.

Cc: Geetha sowjanya <gakula@marvell.com>
Fixes: ae703539 ("octeontx2-af: Cleanup loopback device checks")
Signed-off-by: default avatarRatheesh Kannoth <rkannoth@marvell.com>
Link: https://patch.msgid.link/20260520043036.1523798-1-rkannoth@marvell.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c367b908

drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c

+1 −1
Original line number Diff line number Diff line
@@ -990,7 +990,7 @@ void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf, 
	u16 vf_func;



	/* Only CGX PF/VF can add allmulticast entry */

	if (is_lbk_vf(rvu, pcifunc) && is_sdp_vf(rvu, pcifunc))

	if (is_lbk_vf(rvu, pcifunc) || is_sdp_vf(rvu, pcifunc))

		return;



	blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0);