Commit 9ef30265 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate: Fix segfault on sample histogram 



A symbol can have no samples, then accessing the annotated_source->samples
hashmap will result in a segfault.

Fixes: a3f7768b ("perf annotate: Fix memory leak in annotated_source")
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240510210452.2449944-1-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 09541603

tools/perf/util/annotate.c

+5 −4
Original line number Diff line number Diff line
@@ -113,10 +113,11 @@ static __maybe_unused void annotated_source__delete(struct annotated_source *src 
	if (src == NULL)

		return;



	if (src->samples) {

		hashmap__for_each_entry(src->samples, cur, bkt)

			zfree(&cur->pvalue);



		hashmap__free(src->samples);

	}

	zfree(&src->histograms);

	free(src);

}