Commit 9f157013 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Felix Fietkau
Browse files

wifi: mt76: mt7925: fix locking in mt7925_change_vif_links() 



&dev->mt76.mutex lock is taken using mt792x_mutex_acquire(dev) but not
released in one of the error paths, add the unlock to fix it.

Fixes: 5cd0bd81 ("wifi: mt76: mt7925: fix NULL deref check in mt7925_change_vif_links")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202503031055.3ZRqxhAl-lkp@intel.com/


Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://patch.msgid.link/20250727140416.1153406-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 87f38519

drivers/net/wireless/mediatek/mt76/mt7925/main.c

+3 −1
Original line number Diff line number Diff line
@@ -2069,9 +2069,11 @@ mt7925_change_vif_links(struct ieee80211_hw *hw, struct ieee80211_vif *vif, 
					     GFP_KERNEL);

			mlink = devm_kzalloc(dev->mt76.dev, sizeof(*mlink),

					     GFP_KERNEL);

			if (!mconf || !mlink)

			if (!mconf || !mlink) {

				mt792x_mutex_release(dev);

				return -ENOMEM;

			}

		}



		mconfs[link_id] = mconf;

		mlinks[link_id] = mlink;