Commit 9f35ab0e authored by Dan Carpenter's avatar Dan Carpenter Committed by Bjorn Andersson
Browse files

soc: qcom: mdt_loader: Fix error return values in mdt_header_valid() 



This function is supposed to return true for valid headers and false for
invalid.  In a couple places it returns -EINVAL instead which means the
invalid headers are counted as true.  Change it to return false.

Fixes: 9f9967fe ("soc: qcom: mdt_loader: Ensure we don't read past the ELF header")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/db57c01c-bdcc-4a0f-95db-b0f2784ea91f@sabinyo.mountain


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 9cea10a4

drivers/soc/qcom/mdt_loader.c

+2 −2
Original line number Diff line number Diff line
@@ -33,14 +33,14 @@ static bool mdt_header_valid(const struct firmware *fw) 
		return false;



	if (ehdr->e_phentsize != sizeof(struct elf32_phdr))

		return -EINVAL;

		return false;



	phend = size_add(size_mul(sizeof(struct elf32_phdr), ehdr->e_phnum), ehdr->e_phoff);

	if (phend > fw->size)

		return false;



	if (ehdr->e_shentsize != sizeof(struct elf32_shdr))

		return -EINVAL;

		return false;



	shend = size_add(size_mul(sizeof(struct elf32_shdr), ehdr->e_shnum), ehdr->e_shoff);

	if (shend > fw->size)