Commit 9f5d1a8c authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Steve French
Browse files

cifs: Use kstrtobool() instead of strtobool() 



strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

While at it, include the corresponding header file (<linux/kstrtox.h>)

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarPaulo Alcantara <pc@cjr.nz>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent c9c3395d

fs/cifs/cifs_debug.c

+3 −2
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
#include <linux/fs.h>

#include <linux/string.h>

#include <linux/ctype.h>

#include <linux/kstrtox.h>

#include <linux/module.h>

#include <linux/proc_fs.h>

#include <linux/uaccess.h>
@@ -787,7 +788,7 @@ static ssize_t cifsFYI_proc_write(struct file *file, const char __user *buffer, 
	rc = get_user(c[0], buffer);

	if (rc)

		return rc;

	if (strtobool(c, &bv) == 0)

	if (kstrtobool(c, &bv) == 0)

		cifsFYI = bv;

	else if ((c[0] > '1') && (c[0] <= '9'))

		cifsFYI = (int) (c[0] - '0'); /* see cifs_debug.h for meanings */
@@ -947,7 +948,7 @@ static ssize_t cifs_security_flags_proc_write(struct file *file, 


	if (count < 3) {

		/* single char or single char followed by null */

		if (strtobool(flags_string, &bv) == 0) {

		if (kstrtobool(flags_string, &bv) == 0) {

			global_secflags = bv ? CIFSSEC_MAX : CIFSSEC_DEF;

			return count;

		} else if (!isdigit(flags_string[0])) {