Commit 9f6acd2b authored by Sam Edwards's avatar Sam Edwards Committed by Heiko Stuebner
Browse files

arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls 



The pinctrls for the hym8563 interrupt line and fan-tach input
were both mistakenly defined as `pcfg_pull_none`. As these are
active-low signals (level-triggered, in the hym8563 case) which
may not be driven at times, these should really be pull-up. The
lack of any bias results in spurious interrupts.

Fix this by modifying the `rockchip,pins` properties as necessary
to enable the pull-up resistors.

Fixes: 2806a69f ("arm64: dts: rockchip: Add Turing RK1 SoM support")
Signed-off-by: default avatarSam Edwards <CFSworks@gmail.com>
Link: https://lore.kernel.org/r/20231202071212.1606800-1-CFSworks@gmail.com


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 0c349b50

arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi

+2 −2
Original line number Diff line number Diff line
@@ -235,13 +235,13 @@ &pcie3x4 { 
&pinctrl {

	fan {

		fan_int: fan-int {

			rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>;

			rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;

		};

	};



	hym8563 {

		hym8563_int: hym8563-int {

			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;

			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;

		};

	};