Commit 9f72412b authored by Jiayuan Chen's avatar Jiayuan Chen Committed by Jakub Kicinski
Browse files

ipv6: fix possible infinite loop in rt6_fill_node() 

Sashiko reported this issue [1]. Apply the same fix as
commit f8d8ce1b ("ipv6: fix possible infinite loop in fib6_info_uses_dev()").

Writers holding tb6_lock can list_del_rcu(&rt->fib6_siblings)
without waiting for RCU readers; rt->fib6_siblings.next then still
points into the old ring and this softirq-side walker never reaches
&rt->fib6_siblings, causing a CPU stall. fib6_del_route() always
WRITE_ONCE()s rt->fib6_nsiblings to 0 before list_del_rcu(), so an
inside-loop check is a reliable detach signal.

[1] https://sashiko.dev/#/patchset/20260526020227.4857-1-jiayuan.chen%40linux.dev



Fixes: d9ccb18f ("ipv6: Fix soft lockups in fib6_select_path under high next hop churn")
Signed-off-by: default avatarJiayuan Chen <jiayuan.chen@linux.dev>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260527053133.180695-1-jiayuan.chen@linux.dev


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f72eed9b

net/ipv6/route.c

+2 −0
Original line number Diff line number Diff line
@@ -5902,6 +5902,8 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, 


				goto nla_put_failure;

			}

			if (!READ_ONCE(rt->fib6_nsiblings))

				break;

		}



		rcu_read_unlock();