Commit 9f7e94af authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher
Browse files

drm/amdgpu: Fix off by one in current_memory_partition_show() 



The >= ARRAY_SIZE() should be > ARRAY_SIZE() to prevent an out of
bounds read.

Fixes: 012be6f2 ("drm/amdgpu: Add sysfs interfaces for NPS mode")
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 336568de

drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c

+1 −1
Original line number Diff line number Diff line
@@ -1199,7 +1199,7 @@ static ssize_t current_memory_partition_show( 
	enum amdgpu_memory_partition mode;



	mode = adev->gmc.gmc_funcs->query_mem_partition_mode(adev);

	if ((mode > ARRAY_SIZE(nps_desc)) ||

	if ((mode >= ARRAY_SIZE(nps_desc)) ||

	    (BIT(mode) & AMDGPU_ALL_NPS_MASK) != BIT(mode))

		return sysfs_emit(buf, "UNKNOWN\n");