Commit 9f831c16 authored by Klaus Jensen's avatar Klaus Jensen Committed by Joerg Roedel
Browse files

iommu/vt-d: Remove the pasid present check in prq_event_thread 



PASID is not strictly needed when handling a PRQ event; remove the check
for the pasid present bit in the request. This change was not included
in the creation of prq.c to emphasize the change in capability checks
when handing PRQ events.

Signed-off-by: default avatarKlaus Jensen <k.jensen@samsung.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Signed-off-by: default avatarJoel Granados <joel.granados@kernel.org>
Link: https://lore.kernel.org/r/20241015-jag-iopfv8-v4-2-b696ca89ba29@kernel.org


Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 4d544095

drivers/iommu/intel/prq.c

+2 −8
Original line number Diff line number Diff line
@@ -222,20 +222,14 @@ static irqreturn_t prq_event_thread(int irq, void *d) 
		req = &iommu->prq[head / sizeof(*req)];

		address = (u64)req->addr << VTD_PAGE_SHIFT;



		if (unlikely(!req->pasid_present)) {

			pr_err("IOMMU: %s: Page request without PASID\n",

		if (unlikely(!is_canonical_address(address))) {

			pr_err("IOMMU: %s: Address is not canonical\n",

			       iommu->name);

bad_req:

			handle_bad_prq_event(iommu, req, QI_RESP_INVALID);

			goto prq_advance;

		}



		if (unlikely(!is_canonical_address(address))) {

			pr_err("IOMMU: %s: Address is not canonical\n",

			       iommu->name);

			goto bad_req;

		}



		if (unlikely(req->pm_req && (req->rd_req | req->wr_req))) {

			pr_err("IOMMU: %s: Page request in Privilege Mode\n",

			       iommu->name);