Commit 9faf2072 authored by Felix Gu's avatar Felix Gu Committed by Abel Vesa
Browse files

clk: imx: imx6q: Fix device node reference leak in of_assigned_ldb_sels() 



The function of_assigned_ldb_sels() calls of_parse_phandle_with_args()
but never calls of_node_put() to release the reference, causing a memory
leak.

Fix this by adding proper cleanup calls on all exit paths.

Fixes: 5d283b08 ("clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Link: https://patch.msgid.link/20260203-clk-imx6q-v3-2-6cd2696bb371@gmail.com


Signed-off-by: default avatarAbel Vesa <abel.vesa@oss.qualcomm.com>
parent 4b84d496

drivers/clk/imx/clk-imx6q.c

+4 −0
Original line number Diff line number Diff line
@@ -188,9 +188,11 @@ static void of_assigned_ldb_sels(struct device_node *node, 
		}

		if (clkspec.np != node || clkspec.args[0] >= IMX6QDL_CLK_END) {

			pr_err("ccm: parent clock %d not in ccm\n", index);

			of_node_put(clkspec.np);

			return;

		}

		parent = clkspec.args[0];

		of_node_put(clkspec.np);



		rc = of_parse_phandle_with_args(node, "assigned-clocks",

				"#clock-cells", index, &clkspec);
@@ -198,9 +200,11 @@ static void of_assigned_ldb_sels(struct device_node *node, 
			return;

		if (clkspec.np != node || clkspec.args[0] >= IMX6QDL_CLK_END) {

			pr_err("ccm: child clock %d not in ccm\n", index);

			of_node_put(clkspec.np);

			return;

		}

		child = clkspec.args[0];

		of_node_put(clkspec.np);



		if (child != IMX6QDL_CLK_LDB_DI0_SEL &&

		    child != IMX6QDL_CLK_LDB_DI1_SEL)