Commit 9fb2e20e authored by Ivan Abramov's avatar Ivan Abramov Committed by Steve French
Browse files

smb: client: Remove redundant check in cifs_oplock_break() 



There is an unnecessary NULL check of inode in cifs_oplock_break(), since
there are multiple dereferences of cinode prior to it.

Based on usage of cifs_oplock_break() in cifs_new_fileinfo() we can safely
assume that inode is not NULL, so there is no need to check inode in
cifs_oplock_break() at all.

Therefore, this redundant check can be removed.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarIvan Abramov <i.abramov@mt-integration.ru>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent faf1b648

fs/smb/client/file.c

+1 −1
Original line number Diff line number Diff line
@@ -3082,7 +3082,7 @@ void cifs_oplock_break(struct work_struct *work) 
		cinode->oplock = 0;

	}



	if (inode && S_ISREG(inode->i_mode)) {

	if (S_ISREG(inode->i_mode)) {

		if (CIFS_CACHE_READ(cinode))

			break_lease(inode, O_RDONLY);

		else