Commit 9fcc2b6c authored by Gal Pressman's avatar Gal Pressman Committed by Paolo Abeni
Browse files

net/mlx5e: Fix potentially misleading debug message 



Change the debug message to print the correct units instead of always
assuming Gbps, as the value can be in either 100 Mbps or 1 Gbps units.

Fixes: 5da8bc3e ("net/mlx5e: DCBNL, Add debug messages log")
Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarNimrod Oren <noren@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1762681073-1084058-6-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 43b27d1b

drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c

+16 −2
Original line number Diff line number Diff line
@@ -598,6 +598,19 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_device *netdev, 
	__u64 upper_limit_mbps;

	__u64 upper_limit_gbps;

	int i;

	struct {

		int scale;

		const char *units_str;

	} units[] = {

		[MLX5_100_MBPS_UNIT] = {

			.scale = 100,

			.units_str = "Mbps",

		},

		[MLX5_GBPS_UNIT] = {

			.scale = 1,

			.units_str = "Gbps",

		},

	};



	memset(max_bw_value, 0, sizeof(max_bw_value));

	memset(max_bw_unit, 0, sizeof(max_bw_unit));
@@ -628,8 +641,9 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_device *netdev, 
	}



	for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) {

		netdev_dbg(netdev, "%s: tc_%d <=> max_bw %d Gbps\n",

			   __func__, i, max_bw_value[i]);

		netdev_dbg(netdev, "%s: tc_%d <=> max_bw %u %s\n", __func__, i,

			   max_bw_value[i] * units[max_bw_unit[i]].scale,

			   units[max_bw_unit[i]].units_str);

	}



	return mlx5_modify_port_ets_rate_limit(mdev, max_bw_value, max_bw_unit);