Commit 9ff022f3 authored by Scott Mayhew's avatar Scott Mayhew Committed by Anna Schumaker
Browse files

NFS: check if suid/sgid was cleared after a write as needed 



I noticed xfstests generic/193 and generic/355 started failing against
knfsd after commit e7a8ebc3 ("NFSD: Offer write delegation for OPEN
with OPEN4_SHARE_ACCESS_WRITE").

I ran those same tests against ONTAP (which has had write delegation
support for a lot longer than knfsd) and they fail there too... so
while it's a new failure against knfsd, it isn't an entirely new
failure.

Add the NFS_INO_REVAL_FORCED flag so that the presence of a delegation
doesn't keep the inode from being revalidated to fetch the updated mode.

Signed-off-by: default avatarScott Mayhew <smayhew@redhat.com>
Signed-off-by: default avatarAnna Schumaker <anna.schumaker@oracle.com>
parent 7a84394f

fs/nfs/write.c

+2 −1
Original line number Diff line number Diff line
@@ -1535,7 +1535,8 @@ static int nfs_writeback_done(struct rpc_task *task, 
	/* Deal with the suid/sgid bit corner case */

	if (nfs_should_remove_suid(inode)) {

		spin_lock(&inode->i_lock);

		nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE);

		nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE

				| NFS_INO_REVAL_FORCED);

		spin_unlock(&inode->i_lock);

	}

	return 0;