Commit 9ffc67da authored by Kai Song's avatar Kai Song Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: Use kmemdup() to replace kmalloc + memcpy 



fix memdup.cocci warning:
drivers/staging/r8188eu/os_dep/ioctl_linux.c:4452:33-40: WARNING opportunity for kmemdup

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: default avatarKai Song <songkai01@inspur.com>
Link: https://lore.kernel.org/r/20211003072841.215903-1-songkai01@inspur.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4bea8519

drivers/staging/r8188eu/os_dep/ioctl_linux.c

+1 −2
Original line number Diff line number Diff line
@@ -4183,12 +4183,11 @@ static int rtw_wx_set_priv(struct net_device *dev, 
			kfree(pmlmepriv->wps_probe_req_ie);

			pmlmepriv->wps_probe_req_ie = NULL;



			pmlmepriv->wps_probe_req_ie = kmalloc(cp_sz, GFP_KERNEL);

			pmlmepriv->wps_probe_req_ie = kmemdup(probereq_wpsie, cp_sz, GFP_KERNEL);

			if (!pmlmepriv->wps_probe_req_ie) {

				ret =  -EINVAL;

				goto FREE_EXT;

			}

			memcpy(pmlmepriv->wps_probe_req_ie, probereq_wpsie, cp_sz);

			pmlmepriv->wps_probe_req_ie_len = cp_sz;

		}

		goto FREE_EXT;