Commit a0285236 authored by Jedrzej Jagielski's avatar Jedrzej Jagielski Committed by Tony Nguyen
Browse files

ixgbe: add initial devlink support 



Add an initial support for devlink interface to ixgbe driver.

Similarly to i40e driver the implementation doesn't enable
devlink to manage device-wide configuration. Devlink instance
is created for each physical function of PCIe device.

Create separate directory for devlink related ixgbe files
and use naming scheme similar to the one used in the ice driver.

Add a stub for Documentation, to be extended by further patches.

Change struct ixgbe_adapter allocation to be done by devlink (Przemek),
as suggested by Jiri.

Reviewed-by: default avatarMateusz Polchlopek <mateusz.polchlopek@intel.com>
Co-developed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: default avatarBharath R <bharath.r@intel.com>
Signed-off-by: default avatarJedrzej Jagielski <jedrzej.jagielski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent fd5ef520

Documentation/networking/devlink/index.rst

+1 −0
Original line number Diff line number Diff line
@@ -84,6 +84,7 @@ parameters, info versions, and other features it supports. 
   i40e

   ionic

   ice

   ixgbe

   mlx4

   mlx5

   mlxsw

Documentation/networking/devlink/ixgbe.rst

0 → 100644
+8 −0
Original line number Diff line number Diff line 
.. SPDX-License-Identifier: GPL-2.0



=====================

ixgbe devlink support

=====================



This document describes the devlink features implemented by the ``ixgbe``

device driver.

drivers/net/ethernet/intel/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ config IXGBE 
	depends on PCI

	depends on PTP_1588_CLOCK_OPTIONAL

	select MDIO

	select NET_DEVLINK

	select PHYLIB

	help

	  This driver supports Intel(R) 10GbE PCI Express family of

drivers/net/ethernet/intel/ixgbe/Makefile

+2 −1
Original line number Diff line number Diff line
@@ -4,12 +4,13 @@ 
# Makefile for the Intel(R) 10GbE PCI Express ethernet driver

#



subdir-ccflags-y += -I$(src)

obj-$(CONFIG_IXGBE) += ixgbe.o



ixgbe-y := ixgbe_main.o ixgbe_common.o ixgbe_ethtool.o \

           ixgbe_82599.o ixgbe_82598.o ixgbe_phy.o ixgbe_sriov.o \

           ixgbe_mbx.o ixgbe_x540.o ixgbe_x550.o ixgbe_lib.o ixgbe_ptp.o \

           ixgbe_xsk.o ixgbe_e610.o

           ixgbe_xsk.o ixgbe_e610.o devlink/devlink.o



ixgbe-$(CONFIG_IXGBE_DCB) +=  ixgbe_dcb.o ixgbe_dcb_82598.o \

                              ixgbe_dcb_82599.o ixgbe_dcb_nl.o

drivers/net/ethernet/intel/ixgbe/devlink/devlink.c

0 → 100644
+77 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/* Copyright (c) 2025, Intel Corporation. */



#include "ixgbe.h"

#include "devlink.h"



static const struct devlink_ops ixgbe_devlink_ops = {

};



/**

 * ixgbe_allocate_devlink - Allocate devlink instance

 * @dev: device to allocate devlink for

 *

 * Allocate a devlink instance for this physical function.

 *

 * Return: pointer to the device adapter structure on success,

 * ERR_PTR(-ENOMEM) when allocation failed.

 */

struct ixgbe_adapter *ixgbe_allocate_devlink(struct device *dev)

{

	struct ixgbe_adapter *adapter;

	struct devlink *devlink;



	devlink = devlink_alloc(&ixgbe_devlink_ops, sizeof(*adapter), dev);

	if (!devlink)

		return ERR_PTR(-ENOMEM);



	adapter = devlink_priv(devlink);

	adapter->devlink = devlink;



	return adapter;

}



/**

 * ixgbe_devlink_set_switch_id - Set unique switch ID based on PCI DSN

 * @adapter: pointer to the device adapter structure

 * @ppid: struct with switch id information

 */

static void ixgbe_devlink_set_switch_id(struct ixgbe_adapter *adapter,

					struct netdev_phys_item_id *ppid)

{

	u64 id = pci_get_dsn(adapter->pdev);



	ppid->id_len = sizeof(id);

	put_unaligned_be64(id, &ppid->id);

}



/**

 * ixgbe_devlink_register_port - Register devlink port

 * @adapter: pointer to the device adapter structure

 *

 * Create and register a devlink_port for this physical function.

 *

 * Return: 0 on success, error code on failure.

 */

int ixgbe_devlink_register_port(struct ixgbe_adapter *adapter)

{

	struct devlink_port *devlink_port = &adapter->devlink_port;

	struct devlink *devlink = adapter->devlink;

	struct device *dev = &adapter->pdev->dev;

	struct devlink_port_attrs attrs = {};

	int err;



	attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;

	attrs.phys.port_number = adapter->hw.bus.func;

	ixgbe_devlink_set_switch_id(adapter, &attrs.switch_id);



	devlink_port_attrs_set(devlink_port, &attrs);



	err = devl_port_register(devlink, devlink_port, 0);

	if (err) {

		dev_err(dev,

			"devlink port registration failed, err %d\n", err);

	}



	return err;

}