Commit a03b18a7 authored by Nícolas F. R. A. Prado's avatar Nícolas F. R. A. Prado Committed by Jakub Kicinski
Browse files

net: stmmac: dwmac-mediatek: Fix inverted handling of mediatek,mac-wol 



The mediatek,mac-wol property is being handled backwards to what is
described in the binding: it currently enables PHY WOL when the property
is present and vice versa. Invert the driver logic so it matches the
binding description.

Fixes: fd1d62d8 ("net: stmmac: replace the use_phy_wol field with a flag")
Signed-off-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://patch.msgid.link/20241109-mediatek-mac-wol-noninverted-v2-1-0e264e213878@collabora.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e28acc9c

drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c

+2 −2
Original line number Diff line number Diff line
@@ -589,9 +589,9 @@ static int mediatek_dwmac_common_data(struct platform_device *pdev, 


	plat->mac_interface = priv_plat->phy_mode;

	if (priv_plat->mac_wol)

		plat->flags |= STMMAC_FLAG_USE_PHY_WOL;

	else

		plat->flags &= ~STMMAC_FLAG_USE_PHY_WOL;

	else

		plat->flags |= STMMAC_FLAG_USE_PHY_WOL;

	plat->riwt_off = 1;

	plat->maxmtu = ETH_DATA_LEN;

	plat->host_dma_width = priv_plat->variant->dma_bit_mask;