Commit a0669173 authored by Pagadala Yesu Anjaneyulu's avatar Pagadala Yesu Anjaneyulu Committed by Johannes Berg
Browse files

wifi: mac80211: Fix uninitialized variable with __free() in ieee80211_ml_epcs() 



The cleanup attribute runs kfree() when the variable goes out of scope.
There is a possibility that the link_elems variable is uninitialized
if the loop ends before an assignment is made to this variable.
This leads to uninitialized variable bug.

Fix this by assigning link_elems to NULL.

Signed-off-by: default avatarPagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Reviewed-by: default avatarIlan Peer <ilan.peer@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250609213231.eeacd3738a7b.I0f876fa1359daeec47ab3aef098255a9c23efd70@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 5300e5e2

net/mac80211/mlme.c

+1 −1
Original line number Diff line number Diff line
@@ -10705,8 +10705,8 @@ static void ieee80211_ml_epcs(struct ieee80211_sub_if_data *sdata, 
	 */

	for_each_mle_subelement(sub, (const u8 *)elems->ml_epcs,

				elems->ml_epcs_len) {

		struct ieee802_11_elems *link_elems __free(kfree) = NULL;

		struct ieee80211_link_data *link;

		struct ieee802_11_elems *link_elems __free(kfree);

		u8 *pos = (void *)sub->data;

		u16 control;

		ssize_t len;