Commit a08d4d62 authored by David Gow's avatar David Gow Committed by Shuah Khan
Browse files

drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER 



In order to pass functions to kunit_add_action(), they need to be of the
kunit_action_t type. While casting the function pointer can work, it
will break control-flow integrity.

vc4_mock already defines such a wrapper for drm_dev_unregister(), but it
involves less boilerplate to use the new macro, so replace the manual
implementation.

Signed-off-by: default avatarDavid Gow <davidgow@google.com>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent e847934b

drivers/gpu/drm/vc4/tests/vc4_mock.c

+3 −6
Original line number Diff line number Diff line
@@ -153,12 +153,9 @@ static int __build_mock(struct kunit *test, struct drm_device *drm, 
	return 0;

}



static void kunit_action_drm_dev_unregister(void *ptr)

{

	struct drm_device *drm = ptr;



	drm_dev_unregister(drm);

}

KUNIT_DEFINE_ACTION_WRAPPER(kunit_action_drm_dev_unregister,

			    drm_dev_unregister,

			    struct drm_device *);



static struct vc4_dev *__mock_device(struct kunit *test, bool is_vc5)

{