Unverified Commit a0a28c4e authored by Mateusz Guzik's avatar Mateusz Guzik Committed by Christian Brauner
Browse files

fs: retire now stale MAY_WRITE predicts in inode_permission() 



The primary non-MAY_WRITE consumer now uses lookup_inode_permission_may_exec().

Signed-off-by: default avatarMateusz Guzik <mjguzik@gmail.com>
Link: https://patch.msgid.link/20251107142149.989998-4-mjguzik@gmail.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 3e18f625

fs/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -546,7 +546,7 @@ static inline int do_inode_permission(struct mnt_idmap *idmap, 
 */

static int sb_permission(struct super_block *sb, struct inode *inode, int mask)

{

	if (unlikely(mask & MAY_WRITE)) {

	if (mask & MAY_WRITE) {

		umode_t mode = inode->i_mode;



		/* Nobody gets write access to a read-only fs. */
@@ -577,7 +577,7 @@ int inode_permission(struct mnt_idmap *idmap, 
	if (unlikely(retval))

		return retval;



	if (unlikely(mask & MAY_WRITE)) {

	if (mask & MAY_WRITE) {

		/*

		 * Nobody gets write access to an immutable file.

		 */