Commit a0a2f42a authored by Vincent Donnefort's avatar Vincent Donnefort Committed by Steven Rostedt
Browse files

tracing: Fix unload_page for simple_ring_buffer init rollback 

The unload_page callback expects the return value of load_page() as its
argument: ret = load_page(va); unload(ret). Fix the rollback code in
simple_ring_buffer_init_mm() where the descriptor's VA is used instead
of the loaded page address.

Link: https://patch.msgid.link/20260512141614.1759430-1-vdonnefort@google.com


Fixes: 63592308 ("tracing: load/unload page callbacks for simple_ring_buffer")
Signed-off-by: default avatarVincent Donnefort <vdonnefort@google.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent c2d2856c

kernel/trace/simple_ring_buffer.c

+1 −1
Original line number Diff line number Diff line
@@ -430,7 +430,7 @@ int simple_ring_buffer_init_mm(struct simple_rb_per_cpu *cpu_buffer, 


	if (ret) {

		for (i--; i >= 0; i--)

			unload_page((void *)desc->page_va[i]);

			unload_page(bpages[i].page);

		unload_page(cpu_buffer->meta);



		return ret;