Commit a0c70053 authored by Songtang Liu's avatar Songtang Liu Committed by Joerg Roedel
Browse files

iommu/amd: Fix potential out-of-bounds read in iommu_mmio_show



In iommu_mmio_write(), it validates the user-provided offset with the
check: `iommu->dbg_mmio_offset > iommu->mmio_phys_end - 4`.
This assumes a 4-byte access. However, the corresponding
show handler, iommu_mmio_show(), uses readq() to perform an 8-byte
(64-bit) read.

If a user provides an offset equal to `mmio_phys_end - 4`, the check
passes, and will lead to a 4-byte out-of-bounds read.

Fix this by adjusting the boundary check to use sizeof(u64), which
corresponds to the size of the readq() operation.

Fixes: 7a4ee419 ("iommu/amd: Add debugfs support to dump IOMMU MMIO registers")
Signed-off-by: default avatarSongtang Liu <liusongtang@bytedance.com>
Reviewed-by: default avatarDheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Tested-by: default avatarDheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent dcb6fa37
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ static ssize_t iommu_mmio_write(struct file *filp, const char __user *ubuf,
	if (ret)
		return ret;

	if (iommu->dbg_mmio_offset > iommu->mmio_phys_end - 4) {
	if (iommu->dbg_mmio_offset > iommu->mmio_phys_end - sizeof(u64)) {
		iommu->dbg_mmio_offset = -1;
		return  -EINVAL;
	}