Commit a0cf3654 authored by Jesse Zhang's avatar Jesse Zhang Committed by Alex Deucher
Browse files

drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent 



The pointer parent may be NULLed by the function amdgpu_vm_pt_parent.
To make the code more robust, check the pointer parent.

Signed-off-by: default avatarJesse Zhang <Jesse.Zhang@amd.com>
Suggested-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 05d9e24d

drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c

+5 −1
Original line number Diff line number Diff line
@@ -706,11 +706,15 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params, 
			 struct amdgpu_vm_bo_base *entry)

{

	struct amdgpu_vm_bo_base *parent = amdgpu_vm_pt_parent(entry);

	struct amdgpu_bo *bo = parent->bo, *pbo;

	struct amdgpu_bo *bo, *pbo;

	struct amdgpu_vm *vm = params->vm;

	uint64_t pde, pt, flags;

	unsigned int level;



	if (WARN_ON(!parent))

		return -EINVAL;



	bo = parent->bo;

	for (level = 0, pbo = bo->parent; pbo; ++level)

		pbo = pbo->parent;