Commit a0f0b6d3 authored by Prike Liang's avatar Prike Liang Committed by Alex Deucher
Browse files

drm/amdgpu: fix syncobj leak for amdgpu_gem_va_ioctl() 



It requires freeing the syncobj and chain
alloction resource.

Signed-off-by: default avatarPrike Liang <Prike.Liang@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 16df395a

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+5 −0
Original line number Diff line number Diff line
@@ -107,6 +107,7 @@ amdgpu_gem_update_timeline_node(struct drm_file *filp, 
	*chain = dma_fence_chain_alloc();

	if (!*chain) {

		drm_syncobj_put(*syncobj);

		*syncobj = NULL;

		return -ENOMEM;

	}
@@ -980,6 +981,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data, 
						      timeline_chain,

						      fence,

						      args->vm_timeline_point);

				timeline_chain = NULL;

			}

		}

		dma_fence_put(fence);
@@ -987,6 +989,9 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data, 
	}



error:

	dma_fence_chain_free(timeline_chain);

	if (timeline_syncobj)

		drm_syncobj_put(timeline_syncobj);

	drm_exec_fini(&exec);

error_put_gobj:

	drm_gem_object_put(gobj);