Commit a105db85 authored by Vlad Dogaru's avatar Vlad Dogaru Committed by Jakub Kicinski
Browse files

net/mlx5: HWS, handle returned error value in pool alloc 



Handle all negative return values as errors, not just -1.
The code previously treated -ENOMEM (and potentially other negative
values) as valid segment numbers, leading to incorrect behavior.
This fix ensures that any negative return value is treated as an error.

Signed-off-by: default avatarVlad Dogaru <vdogaru@nvidia.com>
Signed-off-by: default avatarYevgeny Kliteynik <kliteyn@nvidia.com>
Reviewed-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250102181415.1477316-13-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent be482f1d

drivers/net/ethernet/mellanox/mlx5/core/steering/hws/pool.c

+2 −2
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ static int hws_pool_buddy_get_mem_chunk(struct mlx5hws_pool *pool, 
	*seg = -1;



	/* Find the next free place from the buddy array */

	while (*seg == -1) {

	while (*seg < 0) {

		for (i = 0; i < MLX5HWS_POOL_RESOURCE_ARR_SZ; i++) {

			buddy = hws_pool_buddy_get_next_buddy(pool, i,

							      order,
@@ -194,7 +194,7 @@ static int hws_pool_buddy_get_mem_chunk(struct mlx5hws_pool *pool, 
			}



			*seg = mlx5hws_buddy_alloc_mem(buddy, order);

			if (*seg != -1)

			if (*seg >= 0)

				goto found;



			if (pool->flags & MLX5HWS_POOL_FLAGS_ONE_RESOURCE) {